@arghosh93: This pull request references CORENET-6148 which is a valid jira issue.

Hello @arghosh93! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arghosh93
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

yea will open a SBAR and link it here.

@arghosh93: This pull request references CORENET-6148 which is a valid jira issue.

/hold
Till we are working on the SBAR.

/test verify-feature-promotion

@JoelSpeed I think these numbers do not add up

error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over a VRF-Lite configuration Pods should be able to communicate on a secondary network [Timeout:30m] [Suite:openshift/conformance/parallel]" only has 13 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}
error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over the default VRF When the network topology is Layer 2 External host should be able to query route advertised pods by the pod IP [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}
error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over the default VRF When the network topology is Layer 2 Pods should communicate with external host without being SNATed [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}

They run daily and they have been running for more than 14 days. What are we missing?

If for any reason the cluster failed to come up one or two of those days, you'll have missed out on the data as the result wouldn't be recorded for a cluster bootstrapping fail.

The best thing to do here would be to work out which job you need to run to trigger those tests and use gangway-cli to trigger say 5 more runs

If for any reason the cluster failed to come up one or two of those days, you'll have missed out on the data as the result wouldn't be recorded for a cluster bootstrapping fail.

The best thing to do here would be to work out which job you need to run to trigger those tests and use gangway-cli to trigger say 5 more runs

It's strange though that it just happens to those particular test cases if entire jobs failed to run. Will run gangway as you suggested, thanks.

/test verify-feature-promotion

error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [EgressIP] Advertising EgressIP [apigroup:user.openshift.io][apigroup:security.openshift.io] For the default network Pods should have the assigned EgressIPs and EgressIPs can be created, updated and deleted [apigroup:route.openshift.io] When the network is IPv4 [Suite:openshift/conformance/parallel]" only passed 94%, need at least 95% for "RouteAdvertisements" on {metal amd64 ha dual}

@jcaamano we are almost there.

/test verify-feature-promotion

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

The verify lane is looking much better. The tests are at the correct pass rate above 95% on the dualstack lanes we have.

error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {metal amd64 ha ipv4}
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {metal amd64 ha ipv6}
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {aws amd64 ha }
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {azure amd64 ha }
error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {gcp amd64 ha }
F0820 08:20:22.479751   10369 root.go:64] Error running codegen: error: only 0 tests found, need at least 5 for "RouteAdvertisements" on {vsphere amd64 ha }

It's failing for platform reasons. Is this something you can override @JoelSpeed or do we need to do anything on our side.

As for the SBAR: I had opened it 20 days ago: https://docs.google.com/presentation/d/1Ak0bkXFkvoY8JxipMQGct8uCWroPNc84V64PjmXFyek/edit?slide=id.g9814768380_0_0#slide=id.g9814768380_0_0 haven't heard back though @davegord is helping me get some eyes on this.

/hold

please don't remove hold (@jcaamano will do it once we are ready on ovnk/cno side fully) we are only trying to ensure we get this PR to a ready state in parallel.